PCSX2 Documentation/Google Code svn repository comments archive 4750 to 4999

Revision 4750

onepad:

* fix forcefeedback. It works now, albeit it slow down the emulation...

* Add an option hack for ds3 usb drivers

Note: the bluetooth driver (qtsixa) needs some patches to work with SDL (and so PCSX2).

Hum, I'm curious if the slowdown of forcefeedback is specific to my pad driver or the current infrastructure. Feedback are welcome :)

gregory....

Qtsixa's author integrates PCSX2 patch in his git repository :) Hopefully it would make the next release in the coming week.

wing...

I was never able to use diagonals on OnePad. I can set all the buttons just fine but on the D-Pad it only reads Up/Down/Left/Right and not a combination of Up+Right or Down+Forward in-game.

It doesn't happen on ZeroPad tough.

gregory....

thanks for the feedback. I did not test it (can break everything), maybe this small patch can help:

--- plugins/onepad/Linux/linux.cpp (revision 4754)

+++ plugins/onepad/Linux/linux.cpp (working copy)

@@ -132,7 +132,7 @@

{

int value = SDL_JoystickGetHat((pjoy)->GetJoy(), key_to_axis(cpad, i));

- if (key_to_hat_dir(cpad, i) == value)

+ if (key_to_hat_dir(cpad, i) & value)

clear_bit(status[cpad], i);

else

set_bit(status[cpad], i);

Revision 4751

cmake: * improve gtk hack to be compatible with previous cmake version.

* Add some number to the plugin .so file.

Revision 4752

SPU2-X: Improved (hopefully to perfection) the reporting of NAX by moving code

around in the decoder. Fixes Magic Pengel, hopefully no regressions (but it

does intentionally change when some IRQs fire a bit so there might be some, but

if so this is a step towards fixing other finicky games).

ramapcsx2

Another long timer :)

Autor...

BGM Loops in God of War 1 & 2 Fixed *Finally* thanks a lot

ramapcsx2

That'd be awesome!

It's hard to tell with this game but yea, it's still running normally here too :)

sudonim1

Huh, you're right, that does seem to be fixed. I was NOT expecting that.

I wish I could redo this commit just so I could put "fixes god of war" in the commit message.

KrossX3

It seems this also fixes the BGM issues in Tales of Destiny Director's Cut. =O

ramapcsx2

Just need the English translation now! :)

agameofp...

Awesome work, this also fixes the audio desync problems in Pop n Music 13 and 14 in issue 994 , the music now syncs perfectly with the notes. Now there's only a weird issue where the game only scores the notes if you press them right at the bottom of the screen instead of when they touch the red bar, but that's probably another issue entirely, maybe a graphical one. Aside from that, they're perfectly playable now.

pcsx2gu...

Woo finally I'll go ahead and finish God of War, keep it up guys :)

konaj...

the bouncer still has beeping audio issues - anyhow nice work with god of war fix.

emuk...

Zero:akaichou black screen again from this commit, so Neutral

godofdr...

thanks you very much i have been waiting a long time for this fix in god of war 2 keep this perfect work.

avihal

FYI, loading a savestate made with earlier SPU2-X causes pcsx2 to crash (only tried 2 and both load OK with spu2x r4600 and crash with latest spu2x).

The messages at the console stop when loading spu2x:

EE/iR5900-32 Recompiler Reset

Loading GS

Loading PAD

Loading SPU2

avihal

For the sake of the report's completeness, savestates saved with latest spu2x load OK with the same latest spu2x.

avihal

Note, the crash was tested with spu2x r4754 (not this revision).

sudonim1

Oh, 4754 would indeed break savestate compat.

And crap, zero 2 is indeed broken. I must've screwed up, I'll check the code. (Entirely possible that the fixes from this rev will disappear.)

Revision 4753

SPU2-X: Fix minor register logging bug (probably not the only bug in this code)

Revision 4754

SPU2-X: Quality fix (?): take crest value to mean the electronics definition and

clamp modulated pitch to [0,0x3fff] on the basis that the SPU2 probably is

incapable of decoding two words of samples for each voice in each tick.

Honestly this is still guessing, we only really know that it was wrong.

Test FFX tone when it's your turn to act, FFX underwater music?, xenosaga movie

skipping sound effect, god knows what else.

sudonim1

Actually this doesn't even match the electronics definition, but I dunno what's needed here. It can't be anything complicated to calculate or the real SPU2 wouldn't use it.

andutrache

hmm sound seems to be more clear than before, it sounds good in all games i tested

sudonim1

Well, this isn't used much at all so be absolutely sure you know what to test in which games.

Revision 4755

SPU2-X: Refix Zero: Akai Chou (and others fixed in r4735 probably). It was a

slip in the dead voice code.

chenxu...

This is really great! Finaly, the Japanese version of crimson butterfly is running! Good works.

Once FF-X2's movie is also fixed, I will be fully satisfied.

sudonim1

FFX-2 is a terrible game and best left broken, but sadly it'll get fixed as collateral damage sooner or later.

ramapcsx2

lol

prison_b...

@sudonim1 how is it possible that someone doesn´t like ffx-2?

:P

+1 for the fix ;)

andutrache

its very possible, i hate all FFX's.

fagoa...

Agreed, everything after CT was such a letdown XD

SNP_Tira...

+1 to FFX-2 being a terrible game (although I love the battle system... shame it's shackled to a game that is otherwise so horrible). +1 to SPU2-X fixes too.

chenxu...

Well, I love the game, a bright side of the world. Sorry to start this. My bad. Let's respect everybody. Thanks.

ramapcsx2

It would be okay if it had another title and no connection to FFX, imo.

But yeah, seeing this intro sequence was a bit devastating :p

Funny how FF12 has the same problem: Nice game but not a FF title.

Revision 4756

SPU2-X: Bump savestate version since I broke compatibility with r4754

Arkai...

sudonim1, the god of the sound.

One question, it's difficult to add the Reverb x2, x4 based on the actually method.

It's because, for me, there are some games that sound so... dry.

Sorry for my english, surely there are things traducted mmm spanishized.

Thanks a lot.

sudonim1

You're talking about boosting the reverb effect I guess. Our current code has issues. Major issues. Like probably being completely wrong. We need to do some serious testing.

Revision 4757

onepad: support of diagonal in d-pad.

wing...

Thank you!

gregory....

Your welcome, I tested it only 3 minutes this morning. Tell me if you have any issue.

wing...

It works fine!

Revision 4758

SPU2-X: If a bit we don't understand goes high, clear a register we don't

understand. Don't ask me, but it seems to make the BIOS happier and Devil May

Cry works again.

ramapcsx2

// no clue

// yeah

// whatever

xD

(Btw, it was Devil May Cry Pal, a game that always had this "timing problem".)

godofdr...

hi, i just wanted to say thanks for all the bugs you have been fixed and all the time you have been worked on the spu2x so i wanted to say that you check if you can add and copy some of the codes of the spu2null, peopsspu2, zerospu2 plugins becouse i have been seen that on the spu2null plugin wos the BGM Loops in God of War allready fixed so chack this out and thanks again.

and sorry for my bad english.

sudonim1

Looking at the SPU2null code, it's full of incorrect guesses and the code is unreadable and unsafe. There can't be much to learn from it, anything that worked with it worked mostly by accident.

Revision 4759

SPU2-X: Testing showed that writing effect area registers is not entirely

ineffective as previously assumed while effect area writing is enabled on that

core. The new assumption is that internal registers reflect the values of the

external ones while effect area writing is disabled. Also increased logging

level of these registers.

Save state compatibility broken.

Fixes issue 796 , grandia 3 noise before squenix logo.

l3illyl...

Thanks for the fix! It came just in time as I started playing this game the other day.

Does this also fix the same noise occurring randomly throughout the game and in battles? It was the same type of noise that happened when booting the game. I'll test it later tonight.

Revision 4760

SPU2-X: The reverb registers in the register pointer table are inconsistent with

the register definitions, they have always been inconsistent, everything we have

done to fix reverb was invalid because of this. Not sure where we go from here.

ramapcsx2

This was the big problem :)

Revision 4761

SPU2-X: Both cores now (ignore previous commit)

ramapcsx2

This was the big problem :)

Revision 4762

SPU2-X: Reverted back to the last version of the reverb engine before the

rewrite plus some backwards lerp fixes (accident in optimisation in r2089).

Thanks to gigaherz (I guess? This is mostly your fault.)

gigaherz

Well I commited an untested and mostly broken reverb engine, so I had to help undo that. ;P

sudonim1

I'd like to apologise for the jab in the commit message, was just feeling a bit frustrated after finding that years old bug which caused so much unnecessary work.

Revision 4763

SPU2-X: Oops, I'm the one who spotted this when we were discussing it too.

Revision 4764

SPU2-X: Tried to fix the incorrect bitshifts back from when Neill's code was

optimised while the registers were broken so it wasn't testable. My maths is

probably off, the code needs reviewing. The "- 1"s are so that -1 * -1 = just

short of 1 instead of -1 (overflow).

With this, reverb maybe sounds somewhat like the PS2 for the first time ever!?

ramapcsx2

It's close.

Biggest chapter in SPU2-X history comes close to an end with the recent fixes :)

sudonim1

Dunno if that chapter's over yet, but at least it's coming to a close. Can't be much that's horribly broken now.

Cardboar...

HUGE difference this makes after a quick comparison with r4756. Going to test more tomorrow, but seems near perfect. The Custom Reverb option can be removed at the very least. Thanks for all of your work on this.

Revision 4765

SPU2-X: I was being silly, those -1s are unnecessary (I was thinking we were

downcasting for some reason).

godofdr...

very good job keep going.

kaboo...

yo SPU2-X seems to be missing a dependency for the x86emitter didn't look at the code don't know when or why it happened but it's missing it in the trunk

ramapcsx2

It builds fine here in devel and release.

Revision 4766

GSdx: CRC hackixes for...

The Lord of the Rings: the Third Age (Removing fat stripes on screen).

Digimon Rumble Arena 2 (Half screen issue).

Star Wars - The Force Unleashed (Hiding HUD and 3d issues. Not perfect and

NTSC-U only, not sure if it works with PAL).

Star Wars Battlefront 1/2 (Huge VRAM usage issue. NTSC-U only, not sure if it

works with others).

Black Hawk Down - Team Sabre (Half screen issue and removes the night vision

filter which was broken and using a lot of VRAM).

Minimal changes to other CRC hackfixes and GameDB.

gladiato...

NTSC-U only means that you need the CRC of the PAL versions?

I'm asking it 'cause I don't want to test Battlefront 1 or 2 PAL (English, Italian & Spanish) if is not fixed 'cause it freeze my computer.

The same for games like the Third Age (PAL Spanish version), Spider-Man Web of Shadows (Spanish).

So i can provide you those CRC's. Please let me know.

PS: Those kind of fixes can be made for Jackie Chan and others half screen missing issue?

shadowladyngemu

Third age should be working for the PAL version too, if your CRC doesn't match the one I set for it then sure could use your CRC.

I didn't add the Star Wars Battlefront PAL CRCs cause I'm not sure it'll work for them, only way for you to check it would be adding the CRC and risking the freeze as you said. Otherwise you could also provide a GSdump for those and spider-man web of shadows (start the game in software mode then in game press shift+f8 and a .gs .obj and .bmp files should appear in the "snaps" folder, just compress them with 7z/rar and upload them somewhere)

Jackie Chan adventures has a different problem and currently has a hackfix for it too, the hackfix should work for all versions so if you can provide the CRC please do :p

And yes similar fixes could probably be made for other games with same problems.

Revision 4767

SPU2-X:

Removed the fake reverb since the real stuff started to work :)

Revision 4768

SPU2-X: Removed reference to x86emitter as we don't seem to use it any more

(some brief optimisation experiment a while ago?)

Revision 4769

SPU2-X: Another error in the bitshifts, not sure if it's mine or older.

Revision 4770

SPU2-X: More parens needed, always more!

Revision 4771

SPU2-X: We had two SPDIF modes reversed. I don't really understand the SPDIF

modes but these are the bits the library sets. Fixes Gradius 3+4, issue 925 .

refraction

That define should probably be renamed to SPDIF_MODE_USE_BITSTREAM or something really, for consistancies sake.

sudonim1

Eh, I don't know what the bits actually do so I'm leaving sanitising this until I understand the SPDIF functions of the SPU2 better.

gigaherz

"bypass" in there means it bypasses core processing while it's enabled

gigaherz

I hate googlecode not having an edit button...

As far as I know the spu2 has two "bypass" modes, each tied to one of the cores:

One is the pcm bypass, used by the bios' CDDA player. That mode uses 32bit words with the high 24 bits being output to the 24bit DAC in the spu2.

The other is the spdif bypass, which outputs the data into the spdif optical output.

Those flags specifically, refer to what kind of data is the spdif going to output: a 4-channel linear pcm stream, or a compressed bitstream in DTS or Dolby Digital. The data probably uses different interpolation settings and maybe even different bit rates depending on the mode. I never figured that out.

shadowladyngemu

Fixed Grand Theft Auto - Vice City too :)

refraction

bugger me! i knew it was a sound issue, but didnt think something like this would fix Vice City, thought it was an IRQ thingy lol

ramapcsx2

Is it this rev, Lana? The earlier ones make far more sense :p

sudonim1

If there's anything else you know to be a sound issue, please tag it appropriately (SPU2-X, since we do not care about the others and will likely integrate the SPU2 emulation from SPU2-X into the core in the future) in the bug tracker (or create an issue if there isn't one).

refraction

Virtual on mars has a potential sound loop issue, but I haven't checked if that's been resolved yet

shadowladyngemu

Yeh, was this one.

>>If there's anything else you know to be a sound issue, please tag it appropriately

thing is, some older SPU2-X revision let the game go ingame too but it would also run into the loop before, however changing some other settings like EE timing and cycle options would either make it endless loop or going in instantly so it was more random and maybe SPU2-X was just adding to the randomness

but since r4771 it goes in instantly no matter what other settings are set, which makes it almost certain it was SPU2-X, I could make a dump if you guys want to take a look at it or something :p

sudonim1

Well the thing is that this commit affects two things and only two things: sound output, which will never cause any game to hang, and reading the input area... which might.

gigaherz

I'm not sure how the input code looks like atm, but there MIGHT be some differences in the rate at which data is read depending on the mode. That could cause a game to fail if for example spu2-x is reading data faster than it's expected to, and cdvd can't keep up. Probably unrelated but if it was this revision, I'd think more probable its something like that.

Revision 4772

That wasn't supposed to go on the svn :p

shadowladyngemu

my bad :p

Revision 4773

SPU2-X: shifting some code around in the effects engine, any change in output is

probably a bug.

Revision 4774

SPU2-X: Extra clamping. I think we used to have this and it was taken out to

try to boost the reverb.

atia...

wow man, you seriously are on fire ^^

tomaszga...

Thanks for the massive amount of work!

Revision 4775

SPU2-X: Short term reverb quality hack (half the input volume), until we settle

for smth.

Revision 4776

SPU2-X: Forgot to bump the savestate version.

Revision 4777

SPU2-X: Updated the spu2replay engine so it works again. Windows-only still, and

it lacks a proper gui, but it can be used to dump the actions the game is doing

and replay them later without the rest of the emulator.

gigaherz

It's a nice way to listen to games' music, might make a winamp input plugin someday... ;P (don't count on that happening any time soon tho)

omegadox

What about vgmstream?

poisiono...

Intersting Audio-Effects (Reverb based?) sound neat, so i'll gladly add a pre-kick in gigaherts arse as motivation to get that winamp plugin working when time comes ;)

(though i'll probably use it with xmms or such, but still :))

gigaherz

omegadox: As far as I can see, that lib is meant for playing the source files directly. spu2replay's goal is completely different.

It doesn't care about file formats or anything, just of what the games wanted the spu2 to do, and when (register writes, dma writes, ...).

[email protected]: That's part of the reason I decided to get spu2replay working. If we want to fix reverb we MIGHT need to spend some time testing different ways to do "what the spu2 appears to be doing", or tweak some values, and in such cases, its nicer if you don't have to load the whole emulator every time.

omegadox

I see, maybe you can mod vgm to play spu2 dumps :) I see what you mean though, its like the FIFO recorder in Dolphin, in this case you log the commands to the SPU2 chip.

Revision 4778

SPU2-X: Apply Neill's recommended 2/3 multiplier to the input. The results

still are not like on the PS2, but we're now as good as Neill's research allows.

We'll have to do our own from here on.

kaboo...

why "#if 0" and not just comment it out or delete it or is it an actual condition?

if you don't mind me asking^^

sudonim1

I prefer #if 0 to disable code

mailsze...

#if 0 is a precompiler instruction, so the code is not being passed to the compiler. The CPU is not really doing that condition at runtime.

Its just the same as commenting out the code. Just another form of doing it.

sudonim1

It won't do if (0) at runtime either, compilers aren't that stupid. (I couldn't use if (0) here because it's a declaration.)

Revision 4779

SPU2-X: Version bump.

Revision 4780

onepad: create a key_status object to handle key activities with a single

press/release interface

GSdx: remove some linux dialog options which were already controlled by PCSX2

Revision 4781

onepad: slim down a little more the KeyStatus API

Revision 4782

GameDB: Added a lot of games that were missing from the database... still lots

missing tho :p

pg...

Any problems with "Naruto: Uzumaki Chronicles 2 [PAL-E](Multi-5) SLES-55090"?

avihal

Please don't say you did it manually...

Revision 4783

We need to combine these globals into a common struct one day.

This was really unsafe to do. (My fault)

Fixes savestates in Breath of Fire 5.

Revision 4784

Games database: Load from the exe folder (only affects Install mode. Portable

was already OK): Prevent DB-not-found error if previous version wasn't

uninstalled properly.

ramapcsx2

Okay, that's a good one :)

avihal

I hope so ;)

jfre1...

Yay. That bugs been annoying me for ages. Had to have 2 separate pcsx2 folders due to it, just so that it would read the gameindexes.

Revision 4785

Some work on the disc tray code. Got rid of an unsafe global, changed and

commented it a bit.

This is some messy work of mine, gotta admit ><

Revision 4786

Tray code once more:

Added the tray state variable to the cdvd struct, making it safer and taking

care of a previously unhandled situation.

Surprisingly this didn't break old savestate compatibility.

Revision 4787

GSdx: CRC hackfix for Devil May Cry 3, removes bad postprocessing.

Adjusted the SW Battlefront hackfix for the PAL versions (NTSC-U and PAL

versions have the same CRC but use slighty different buffer/texture

addresses...)

shadowladyngemu

Only removed the really obstructive postprocessing in DMC3, the others can be removed with "Alpha hack".

http://i.imgur.com/WeiRm.jpg

http://i.imgur.com/L6GJk.jpg <-- with alpha hack

godofdr...

thanks for the fix and i wanted to ask one thing if you are man or woman?

becouse your name is with lady and i never see some programar with is woman

so i wanted to now if this ok for you

and sorry for my bad english.

wespipe...

Thanks for the DMC3 fix! Always welcome!

Is the screen still squashed?

shadowladyngemu

@godofdrive:

I'm a woman and I'm no programmer :p

@wespipes69:

Not for NTSC with the CRC hack, for PAL only on the 60Hz mode but the 50Hz one is fine.

Hefra...

A thousand thanks for the DMC3 hack :)

I've been meaning to do this myself for months, but I could never find enough time to get round to it. Now I still don't have the time, but at least I also don't have the problem :)

Thanks again!

serban.a...

also shadowlady is the name of an anime series:P

godofdr...

ok, so how you shadowlady now how to fix some bugs that man cannot fix can you explein it to me.

thanks and sorry again for my bad english.

pcsx2gu...

ok, so how you shadowlady now how to fix some bugs that man cannot fix can you explein it to me.

thanks and sorry again for my bad english.

It must be because she's a woman!!111 A witch or something. -_- Give us a break dude.

prison_b...

I think it actually looks cool without the alpha hack (the sunny effect) :P

+1 for the fix tough :D

godofdr...

ok sorry man i just very love the pcsx2 so sorry.

and take the break that you whant i dont mean to Disturb you.

sorry again

lemuel2010

CRC hackfix very good!!!!!!

ramapcsx2

Women coders aren't even *that* rare.

gladiato...

Devil May Cry 3 works perfect.

Awesome!.

Thanks also for the other CRC's that you added.

Revision 4788

whoopsie

miser...

Hehe:3

Revision 4789

onepad: remove deadcode

zzogl-pg: disable opengl3 context creation for the moment (crash with geforce7)

Revision 4790

GSdx: CRC hackfix for Burnout games, removes garbage from screen.

shadowladyngemu

Not sure what's with the black sky in this games...

If you start a race in hardware mode, sky is black and if you switch to software mode sky remains black.

If you start a race in software mode, sky appears and if you switch to hardware mode sky remains working even for other races...

maksre...

devil may cry fixed menu

desaste...

hi shadowlady, i don't know if this helps but another way to make the garbage disapear was by skipping the bios, this helps not only in the burnout games but also in god of war with the fog... but then the language is only in english, which kinda sucks for the pal users in one of the not english languages.... maybe you can combine the two methods or somwhat...

lemuel2010

Good!!When Jak's graphic fix?

shadow0...

Gabest fixed a bug with a similar behavior (texture corruption?) for Gunbuster, basically the background, which could be a skybox would be corrupted if entering the game on hardware I believe, switching to software didn't fix the output, it was fine when entering on software, and changing to hardware then produced no error.

I am not sure if it was a gamefix though, it could also be completely unrelated.

shadowladyngemu

May be related, but unfortunately it wasn't a game specific hackfix :p

grove4...

Nice one but it does not work on my version

(Burnout 3 - Takedown PAL German CRC:CE49B0DE)

could you add it to the CRC list in one of your next patches

Thanks

Revision 4791

GSdx: CRC hackfix for Midnight Club 3, fixes the huge vram usage when moving.

Small change to the Burnout hackfix, was skipping too much for NTSC.

andutrache

Burnout fix working like a charm :) .

beatle...

If only you could fix the black vertical stripes in Tekken TT and Tekken 5 at high resolutions that would be amazing

marius.h...

Since you seem to do some CRC hackfixing right now, could you please take a look at this issue? https://code.google.com/p/pcsx2/issues/detail?id=1050&colspec=ID%20Status%20Priority%20Component%20Plugin%20Owner%20Summary&start=100

Refraction thought it might be a CRC problem, but he seems to have forgotten about this by now^^.

animatri...

in mid night club 3 dub edition im still gettin huge slowdowns...

do i have to enable something for it to work?

refraction

marius: You never gave us your CRC so i couldnt check :P only the US versions have been added here.

marius.h...

Ah OK^^. Sorry for the misunderstanding then :). But how do I create a CRC? I searched for this before but I only really found a single program someone coded for which I unfortunately lost the link by now. But I do have the CRC it gave me for Lucifer's Call still here: 0x4bdf6d2c

But I'm not sure if this number is right or if it was a good program I used. Can you perhaps link me one please?

shadowladyngemu

@animatrix999:

It's a CRC specific gamefix, if your game has a different CRC or is a different version (could be PAL) then please post the version and CRC for it here so they can be added later.

shadowladyngemu

That's the "Remix" version and that one has the fix...

When you run the game and get those slowdowns what do the EE/GS% in game window say?

animatri...

when im driving

EE:35-50%

GS:95-100%

hope dis helps

stian...

Hmm, I'm not sure how this works... am i suppose to create those files, save them with the other GSdx files and then it works? ^^

I play Lotr The third age, and i have those black vertical stripes all over, so anoying. got here but im not sure what to do xD Plz help :)

Revision 4792

whoops...

it kinda works better if you make the hackfix use the function...

GSdx: Dragon Ball Z Budokai Tenkaichi 2's hackfix works with NTSC version now

too.

Revision 4793

Lilypad: Disable a confusing control for now.

Also a small comment on GSdx's texture cache lookup.

Revision 4794

Lilypad: Don't screw users which already had the problematic option set.

Revision 4795

Lilypad: Really hide the option. Sigh :p

avihal

:P

konaj...

Why disable this? This allows the plugin to auto enable analog mode rather then having to manually assign and press a hotkey, lilypad is also a psx emu compatible plugin and this option helps since most psx emulators disable analog by default.

jfre1...

If that's the case I have to second konaj on that one.

ramapcsx2

It works for PSX emus? Didn't know.

We're disabling this option because people enabled it, thinking it would be a good idea.

Unfortunately it kills the input in many games and people simply don't remember turning this on.

Personally, I don't care about PSX emulator compatibility.

There's tons of nice plugins for these already.

andutrache

erm i really suggest you guys read the title of the page again, this is a PS2 emulator SVN, its purpose is to help post revs that raise compatibility of PCSX2.

Any other software is out of the question.

If you want a pad plugin for PSX use SSSPSX Pad Plugin.

konaj...

Disagree, just because it's in the pcsx2 svn doesn't mean its for pcsx2 only, this is the only svn for the plugin and the original authors intended it to work with psemu emulators too. same goes for gsdx and peops spu, ripping out the psx support code wont speed up or raise compatibility any.

lilypad is the only plugin that can get the force feedback settings right for a lot of controllers/adapters for psx and ps2.

(SSSPSX Pad Plugin and most others mess the motor sequence up)

anyways since the original author designed this plugin with ps2 in mind first that option must also have some relation to the ps2...I always had it enabled and never had a problem.

ramapcsx2

Try to play ICO or any other game written with a restrictive pad library then.

The code for this option is broken somehow.

Until we can figure it out and correct it, this game breaking option is best hidden from users.

ramapcsx2

Oh and yea, as far as I'm concerned, this is a PS2 plugin only :)

GSdx supporting PSX emus was a bad idea as well.

Intellisense still likes to direct us to PSX functions, code generation takes longer and most importantly: There's several better plugins already available.

PEOPS SPU (1) is a different plugin entirely.

miser...

I really doubt that people who use this for psx emulators wouldn't know how to revert that change for their own use.

avihal

Please check r4797 and comment back if it's working as desired in PS1 emulators.

Revision 4796

GUI: Open the main window (if required) before the console window. Results: 1.

Taskbar order is now better. 2. Console window gets minimized with the main

window. Thanks to ShadowLady for the code.

ramapcsx2

Seems good so far :)

miser...

Nice ;3, never noticed it wasn't minimizing together before O.o

vsu...

If you ask me it works even worse now.

The gui was always getting in the way and when I try to minimize it,it was also minimizing the game window but now when I try to minimize the gui,it's minimizing everything(all 3 windows)

Why windows should be connected?

This is how it works now

1.Minimizing the game window - minimizes only the game window(that's perfect)

2.Minimizing the log window - minimizes also the gui

3.Minimizing the the gui - minimizes the gui,log and the game window

This is how it worked before

1.Minimizing the game window - minimizes only the game window(that's perfect)

2.Minimizing the log window - minimizes only the log window(that's perfect)

3.Minimizing the the gui - minimizes both the game window and the gui(here's the problem)

avihal

[email protected], first of all, minimizing the console doesn't minimize the GUI. Only change is that when minimizing the main window it now also minimizes the console.

The concept is that the main window minimizes everything, but each window minimizes only itself. Untill now, the console was the exception, and you'll have to agree that it's an unreasonable exception.

vsu...

I know but how I'm I suppose to to minimize only the gui without minimizing everything else?

Now if I want to minimize only the gui,I have to restore both the game window and the console

Wouldn't be better(if possible)to have an option in the pcsx2 ini for when it's set to 0 to minimize all when you try to minimize the gui and 1 to be able to minimize every window separately.

This "problem"(for me)was always bugging me and now it's even worse...when I'm constantly switching windows(when I'm creating cheats or test something)

avihal

Each new option adds more code and more potential for bugs. Sometimes it's worth adding more options, but at some point the developers have to decide what stays as an option and what gets hardcoded into the application. On this case, my personal view is it it shouldn't be an option (however, if I'm convinced that most users would benefit from a change, we always listen).

I think that most users would benefit from this more consistent behavior, however, you can compile the code yourself with the following modifications to make both the GS window and the console window stay open when minimizing the main window:

1. At file AppInit.cpp, replace the line:

m_ptr_ProgramLog = new ConsoleLogFrame( GetMainFramePtr(), L"PCSX2 Program Log", g_Conf->ProgLogBox );

with:

m_ptr_ProgramLog = new ConsoleLogFrame( NULL, L"PCSX2 Program Log", g_Conf->ProgLogBox );

2. At the file FrameForGs.cpp, replace the line:

: wxFrame(parent, wxID_ANY, title,

with:

: wxFrame(NULL, wxID_ANY, title,

I only tested it a little so I'm not sure what other effects it might have, but it seem to work.

Revision 4797

Lilypad: re-enable "Auto Analog" option, but only use it when not in PS2 mode

(in PS2 mode this option is ignored). Tested with ICO - previously wouldn't

accept control input when in autoAnalog mode, now always works.

miser...

And so everyone happy :P

konaj...

thanks for the fix tested with chrono cross and the analog option was lit up automatically so looks like its working with ps1, the option is also visible in lilypad config.

ps2 mode is greyed out & disabled.

nice work :)

Revision 4798

x86 emitter: fixed three encodings for shrd and shld, as in issue 1076 . Thanks

to "firnis" for finding this.

sudonim1

Note: won't change compatibility, it'll just prevent crashes if we choose to use these instruction formats in the future.

sudonim1

Now someone should inform intel that the opcode field in their instruction set reference manual is wrong, which is probably how this happened :P

gabest11

If I look at xbyak, it should be OpcodeBase + (clreg ? 1 : 0).

gabest11

Which actually makes it correct, since it is the cl version.

Revision 4799

EE: reviewed, simplified and corrected (at least three bugs including issue

1078 ) left and right loads and stores. Probably a waste since there's a much

smarter way to do these.

sudonim1

I missed something.

sudonim1

Oh right, ebx has a special use in our code.

sudonim1

...hmm, and in addition to that I think I've found another recompiler bug outside this code.

sudonim1

Yes, I'm pretty sure I've found a constprop bug, investigating further.

Revision 4800

EE: Put _Rt_ checks back in the load instructions because as silly as it would

be we must avoid potentially writing to r0.

Revision 4801

EE: Fixed my use of ebx in a load/store implementation (reserved for return

address) and changed _deleteEEreg to do what it says when also flushing and

changed most uses of _deleteEEreg with the flush parameter set to 1 to

_flushEEreg. May introduce or fix bugs.

Revision 4802

Fix for Endgame which tries to do 0 sector CDVD reads.

azte...

it's good to see fixes in place not much visited by developers, thank you. ;)

nefer...

This gives some progress in "Spyro the Dragon - Enter the Dragonfly", it passes the first screen it was always stuck at and shows some more screens and then tries to go to menus but then it's a black screen with music :S

azte...

nefer - usa, europe or jap version?

ramapcsx2

Cool then :)

Revision 4803

EE: Changed some load/store flushing behaviour for better efficiency (and

hopefully no bugs). Changed my mind about the internals for future exception

handling so scrapped what we have for now. Also restored correct rt=r0

behaviour on all loads.

Should be a small boost in fps everywhere and otherwise likely not change

anything.

ColinTre...

"Should be a small boost in fps everywhere" Sounds like a good commit to me.

avihal

FYI tested performance on a single, non representative, Killzone 1 warscenes 10s replay (with slight speed hacks), compared to r4796.

In my test, r4803 is consistently slower about 1.5% than r4796.

Test was done using pcsx2bench, with the following batch file (executes 4 times in a row: load state, wait 4 seconds, then measure performance for 10s, repeat):

for /l %%i in (1,1,4) do pcsx2bench -nokey -bench10 -fps50 -quiet

Results for r4796:

Avg speed: 114.53%, FPS: 51.06 - 68.18, pcsx2bench rating: 100.0

Avg speed: 114.53%, FPS: 51.02 - 67.56, pcsx2bench rating: 100.0

Avg speed: 114.78%, FPS: 52.06 - 67.41, pcsx2bench rating: 100.0

Avg speed: 114.43%, FPS: 50.98 - 68.05, pcsx2bench rating: 100.0

Results for 4803:

Avg speed: 112.70%, FPS: 50.68 - 66.52, pcsx2bench rating: 100.0

Avg speed: 112.90%, FPS: 50.60 - 65.80, pcsx2bench rating: 100.0

Avg speed: 113.11%, FPS: 51.22 - 65.73, pcsx2bench rating: 100.0

Avg speed: 113.16%, FPS: 51.28 - 66.28, pcsx2bench rating: 100.0

FYI.

sudonim1

Okay, that's weird, but please test against r4802 instead.

avihal

Did few alternating bench tests, no speed hacks this time (full default settings). Here are the results, in the order of testing (tested on Windows XP 32 SP3, E8400@3GHz, GTX260):

r4802:

Avg speed: 95.33%, FPS: 43.50 - 56.97, pcsx2bench rating: 93.2

Avg speed: 95.26%, FPS: 43.46 - 56.75, pcsx2bench rating: 93.1

Avg speed: 95.36%, FPS: 43.36 - 56.94, pcsx2bench rating: 93.1

Avg speed: 95.27%, FPS: 43.46 - 56.53, pcsx2bench rating: 93.2

r4803:

Avg speed: 92.58%, FPS: 41.98 - 54.48, pcsx2bench rating: 90.4

Avg speed: 92.46%, FPS: 42.50 - 54.33, pcsx2bench rating: 90.8

Avg speed: 92.59%, FPS: 42.42 - 54.30, pcsx2bench rating: 91.0

Avg speed: 92.66%, FPS: 42.51 - 54.58, pcsx2bench rating: 91.4

r4802:

Avg speed: 96.19%, FPS: 44.17 - 56.97, pcsx2bench rating: 94.1

Avg speed: 95.87%, FPS: 44.09 - 56.68, pcsx2bench rating: 93.9

Avg speed: 95.99%, FPS: 44.29 - 57.09, pcsx2bench rating: 94.1

Avg speed: 95.80%, FPS: 44.03 - 56.96, pcsx2bench rating: 93.6

r4803:

Avg speed: 93.34%, FPS: 42.72 - 54.41, pcsx2bench rating: 92.1

Avg speed: 92.88%, FPS: 42.75 - 54.43, pcsx2bench rating: 91.3

Avg speed: 92.92%, FPS: 42.80 - 54.32, pcsx2bench rating: 91.2

Avg speed: 93.10%, FPS: 42.56 - 54.43, pcsx2bench rating: 91.6

ramapcsx2

I saw less of a difference, but yea, this rev is ever so slightly slower than r4802.

It's nearly not measurable here though, prolly because I have the recommended speedhacks enabled.

ramapcsx2

It's faster on FMV's :p

xse...

Much more efficient and now hardly reaches 100% EE Valkyrie Profile 2 making the game much more smooth and with less sound creakings

Phenon II [email protected]

miser...

Not much of a test, but Star Ocean 3 which I was just playing seems to use like 5% on average less EE% to get to full speed in compare to previous, nice speedup^_^. Also like above AMD cpu.

chenxu...

I tested it with Warship Gunner 2. The thing goes from 47~48fps to 48~49fps. So I believe speed up exist.

chenxu...

Tested with a battleship with more parts in another scene in Warship Gunner 2. The speed goes from 41~42fps (4796) to 43~44fps (4803).

My system is [email protected] and GTX460.

Revision 4804

cmake: be sure wx is present before fiddling with the include path

maksre...

Devil May Cry fix menu please

andutrache

sorry the team does not take requests.

Revision 4805

cmake:

* use the standard 3 step flow: cmake, make, make install

* Remove L10N_PORTABLE option, superseeded by PACKAGE_MODE

* Extend PACKAGE_MODE to select the install directory (FHS or local bin)

rafael.f...

Cool. This L10N_PORTABLE always got me confused. :)

By the way, there is still a comment about its usage in the beginning of BuildParameters.cmake

rafael.f...

Also, Archlinux packaging standards request plugins at /usr/lib/pcsx2, which is different from Debian, etc. Is it possible to make the destination folder be flexible? It would be great if I could set the destination folder in cmake command line... Please add this the TODO list. :)

Thanks

gregory....

Well, actually I do not know what is the exact Debian requirement. But yes I could manage to add an option.

rafael.f...

As far as I can tell, you used the exact standard, according to Debian Policy Manual, chapter 9. Archlinux, on other hand, uses its own hierarchy ("Arch Packaging Standards"). Can't say about other distributions, though.

off topic, but nice work with "make install". Saved me some lines in my package's "rule" script.

gregory....

Hum, there are some discussions on going inside Debian to drop "games" part. Moreover technically PCSX2 is not a game but an emulator (of games).

By the way I need to figure out how to align PCSX2 with install path. It would reduce further packaging burden.

gregory....

see r4811 and r4812. Now you can tune cmake for your distribution. C++ code is automatically aligned with the option so you don't need anymore to patch the code.

Revision 4806

debian: align the package with latest cmake change.

Revision 4807

EE: very minor VTLB optimisation. Smaller than r4803 probably (but shouldn't

have any possibility of slowing down any code).

ramapcsx2

Hmm, no measurable difference in 3 games tested.

Still nice :p

Revision 4808

Just a couple CRC and GameDB updates.

jfre1...

Any games fixed by this?

Revision 4809

SPU2-X:

Adding an option for the de-alias filter implemented in r4118,

currently overemphasizes the highs so it's disabled by default

but I like it for some games :P

avihal

:)

ramapcsx2

Nice job there!

You going to take the gui stuff task from me now? :D

Revision 4810

SPU2-X: Fix the linux version, and add a checkbox for the de-alias filter.

shadowladyngemu

knew I forgot to finish something, my bad :p

arcum42

Not a problem. I was looking for something to work on anyways...

Revision 4811

pcsx2, zzogl-pg: allow to change some default path with compilation flags.

cmake: Add PLUGIN_DIR and GAMEINDEX_DIR options to easily select install

directory. Install GameIndex.dbt during install phase.

rafael.f...

ZZogl crashes in game init. Log output: http://pastebin.com/6PTCZPVz . Maybe it was not set in ZZoglCreate.cpp to find ps2hw.dat in /usr/share/games/shaders ?

But the rest of plugins and the DB are working fine. Thanks.

gregory....

Arg, I need to find a way to test it properly (my gl drivers does not work for the moment). Probably an issue with the macro.

gregory....

Note, I change the behavior and it will look at $PLUGIN_DIR directory not /usr/share/games/shaders anymore.

rafael.f...

Related to ps2hw.dat, ps2hw.dat is set install in /usr/share/games/shaders. See zzogl's CMakeLists file.

Related to tests, don't worry. I'll be here bugging you. j/k :D

gregory....

Ouppps. I fix that tommorrow.

gregory....

Ok. Done.

gregory....

Rafael, could you send me the files to build an arch packages? I'm curious of how it is working on Arch. And maybe it can help me or Fedora users for a rpm package creation.

rffonten...

Only the files or you want a how-to install from the beginning ?

pcsx2-svn (version update on-the-fly): http://aur.archlinux.org/packages/pcsx2-svn/pcsx2-svn.tar.gz

pcsx2-bin (binary) http://aur.archlinux.org/packages/pcsx2-bin/pcsx2-bin.tar.gz

If you want to know more, you can read about creating and building packages in Archlinux in https://wiki.archlinux.org pages:

- Pkgbuild

- Creating_packages

- Makepkg

- Arch_User_Repository (a.k.a. AUR)

- Arch_Packaging_Standards

Or ask me. Let me know if I can help more.

gregory....

Thanks I wanted to see the pkgbuild script.

Revision 4812

debian: reduce package complexity. Merge pcsx2-data (only 2 files) into pcsx2

and pcsx2-plugin.

Revision 4813

cmake: generate resource outside of the source tree.

Debian: remove useless clean file

Revision 4814

wiki: linux 32bits various update

Revision 4815

cmake: fix install directory of shader file in package mode

godofdr...

i want to see a Serious fixes like "god of war 2 pal with the fog"

and in "fifa street 2" the maps are with black screens and other

i Appreciate all that you have done and thanks for all of this is the best emulator on the planet the fastest and the stable not like others.

and good job thanks.

and sorry for may bad english

gregory....

I understand. Well did not GSdx have already a hack for GoW2?

Anyway on Linux, distribution and compilation are important. There are lots of guys that cannot use PCSX2 because they can not compile/install it. Moreove we cannot provide a binary for all linux users and it will become a nightmare in the near future.

ramapcsx2

Don't worry gregory, users demand stuff we can't provide all the time :p

ColinTre...

I want to see every game running at 1080p with full FPS and no graphical errors.

Right now! =p

ex1991e...

"Comment by [email protected], Today (2 hours ago) I want to see every game running at 1080p with full FPS and no graphical errors.

Right now! =p"

Now that, is an impossible feat. Come on be more realistic . The developers of pcsx 2 are only doing this during their free time and I don't think there has been or will be any long breaks or holidays for them to even achieve such a goal. In order for them to even achieve such a goal, gsdx would have to be overhauled and among other things. Which would obviously take a long time, so be patient. I for one, am just grateful for what they have achieved so far. Anyway keep up the good work, pcsx 2 team. On a side note, I just hope you guys are doing ok, with out Jake Stine (Air).

shadowladyngemu

i want to see a Serious fixes like "god of war 2 pal with the fog" <-- I think I did that some time ago in GSdx and just didn't announce it, didn't think it was needed... and I assume this is about GSdx since only the PAL version was still having a problem with it... so I don't see what does that have to do with this rev... :p

godofdr...

ok,thanks for all and i dont understand what you told shadowlady i dont understand how to Continue after the fog if you can tell me how to fix this so it will be Pleasure.

thanks again and sorry for my bad english.

zantezuken

@ramapcsx2

I demand PS3 support.

Pretty please?

rafael.f...

Ok, time to create PCSX3 dev team. :D

@gregory, Thanks for fixing ZZogl installation in linux.

gregory....

Well it did not work actually. I open the directory inside zz instead of the file...

gregory....

Now it really works :)

poisiono...

Grand, coming home from a visit with a new gf and finding some cmake love :)

Revision 4816

Silence a SIF dma warning.

ramapcsx2

Ace Combat 5 was spamming this.

DanrleiS...

perfect timing to fix directx10 in dragon quest VIII

I see some speedup into 3 fps ^

Revision 4817

zzogl-pg: open the dat file...

Revision 4818

Reverting r4796 (Console window now opens again before main window). Reason: The

console window's menus were overlapping the main window menus, leading to main

window menu actions getting invoked when using the console menus...

avihal

Adding for reference: r4796 apparently also caused main window to not appear on the windows list (see http://forums.pcsx2.net/Thread-ArtMoney-and-pcsx2-after-r4796 )

Revision 4819

GSdx: Fix an old and silly bug that could cause slowness in native resolution

hardware rendering. Thanks for debugging, Lana and avih.

chuuey

wow, nice work :D

azte...

this doesnt fix 1/more issues?

ramapcsx2

It applied upscale correction hacks to native resolution rendering.

Pretty bad thing :p

avihal

Lana actually did the code debugging, after we discovered simultaneously that that while native is checked, speed still depends on the value of the grayed out scaling field.

ramapcsx2

It's still pretty strange how that scene incurs an additional slowdown.

All it did was add some extra processing for the (not needed) hacks.

Oh well, this code should get some thorough renovation anyways.

It works for now :p

cristian...

HI,..i have a big problem with directx 11 (LOGO) real detection and FPS.

When I selected DX11, logo show just DX10 and FPS is < 09.

I test on Soul Calibur III.

Is just a GSDX problem.

When i play on GSDX 120 (valdanx) on pcsx r4819, FPS is > 50 and the logo is DX11!

My cfg. is: windows 7 ultimate x64, Intel CPU=Q9550 (2,8ghz), 4gb ddr2(1066), VGA=HD5770, real DX11(1024MB), my VGA catalist driver version is 11,6.

I have install VC++ 8 and 10, directx_Jun2010_redist, DXSDK_Jun10, dxwebsetup.

PLEASE HELP ME!

ramapcsx2

cristian:

Please bring your problem to our forums.

http://forums.pcsx2.net/index.php

refraction

"When i play on GSDX 120 (valdanx) on pcsx r4819, FPS is > 50 and the logo is DX11!"

I wouldnt trust Valdanx builds...

Revision 4820

SPU2X: New (simpler) time stretcher algorithm.

Should prevent erratic tempo variations near 100% speeds (compared to the

previous implementation), and generally allow much lower latencies while keeping

the audio stable (on all audio systems).

E.g. my tests show that at 70ms latency it can properly handle sharp speed

variance of 50%-100%. If your game generally doesn't get slower than 70% speed,

50ms latency would probably be fine.

Note that on extreme scenarios (e.g. extreme sharp drops in speed) it doesn't

try to keep the audio continues at all costs. If your game exhibits such

behavior (audible clicks, etc), increasing the latency a bit at the config would

help.

Comments on actual performance/quality on different systems would be greatly

appreciated.

andutrache

this is very nice :))

good job !!!

refraction

Awsome! well done mate :)

ramapcsx2

Thanks a bunch, avih.

I spent ages wrestling the stretcher :p

cristian:

Please bring your problem to our forums.

http://forums.pcsx2.net/index.php

cristian...

You did a great job man, I put my problem on the forum.

cottonvibes

haven't tested it yet, but this was something that was badly needed :p

Revision 4821

Big gif transfer code rewrite!

Pcsx2 now has a gifUnit class which acts like the ps2's gif and executes a

single gif transfer at a time (and performs path arbitration according to

priority and path3 slicing).

This new code is generally a speedup for most games. Particularly VU heavy games

like GoW.

This revision breaks old saved state compatibility so don't update if you wish

to keep playing with your old saved states.

Leave comments if this revision fixes or breaks anything...

Message to GS Plugin authors:

This new code now uses only 1 gif callback to transfer data to the gs plugin

(GSgifTransfer).

pcsx2 also is garaunteed to send full GS primitives to the plugin. So you don't

have to account for partial-transfers anymore.

Thanks goes out to shadowlady who tested around 500 games for me :D

Note 1: The old gif code is still in this revision, and can be enabled by the

USE_OLD_GIF macro. The old code will be deleted soon.

Note 2: This revision also enables assertion dialogs in devel builds, and

changed a lot of assume cases into assertions.

shadowladyngemu

Compiles with VS2008 but VS2010:

12>SaveState.obj : error LNK2001: unresolved external symbol "protected: void __thiscall SaveStateBase::gifFreeze(void)" (?gifFreeze@SaveStateBase@@IAEXXZ)

12>FiFo.obj : error LNK2001: unresolved external symbol "bool __cdecl Gif_HandlerAD(unsigned char *)" (?Gif_HandlerAD@@YA_NPAE@Z)

12>FiFo.obj : error LNK2001: unresolved external symbol "void __cdecl Gif_FinishIRQ(void)" (?Gif_FinishIRQ@@YAXXZ)

12>FiFo.obj : error LNK2001: unresolved external symbol "struct Gif_Unit gifUnit" (?gifUnit@@3UGif_Unit@@A)

12>FiFo.obj : error LNK2001: unresolved external symbol "void __cdecl Gif_AddCompletedGSPacket(struct GS_Packet &,enum GIF_PATH)" (?Gif_AddCompletedGSPacket@@YAXAAUGS_Packet@@W4GIF_PATH@@@Z)

12>FiFo.obj : error LNK2001: unresolved external symbol "void __cdecl Gif_AddBlankGSPacket(unsigned int,enum GIF_PATH)" (?Gif_AddBlankGSPacket@@YAXIW4GIF_PATH@@@Z)

12>FiFo.obj : error LNK2001: unresolved external symbol "void __cdecl Gif_MTGS_Wait(void)" (?Gif_MTGS_Wait@@YAXXZ)

ramapcsx2

Good job actually going through with this! :)

KrossX3

It seems the new files were just not added to the pcsx2.vcxproj.

ramapcsx2

All those usually flickering FMV are now showing inverted colors (and flicker).

There's something going on with GIF and GSdx hardware here :p

Line.E...

PCSX2 alive and kicking !!! (^_^)

romulux_...

Nice comeback cotton, good effort, it seems activity has flourished again!

refraction

wow, good job! hopefully makes my life easier too lol..

hope path3 masking still works ;p

avihal

Amazing effort :)

Wagnar...

Good Job. 500 games tested? all legit :P ?

godofdr...

woow, really very good job i even cannot check 15 games and you shadowlady checked 500 games. its a very big joob i Appreciate it thanks for all.

sorry for my bad english

luc...

I get a linking error on Linux, GCC 4.6.1

Configured with -DCMAKE_BUILD_TYPE="Debug" -DPACKAGE_MODE=TRUE -DFORCE_INTERNAL_SDL=TRUE -DCMAKE_INSTALL_PREFIX="/usr" -DPLUGIN_DIR=$plugindir -DGAMEINDEX_DIR="/usr/share/pcsx2"

Linking CXX executable pcsx2

CMakeFiles/pcsx2.dir/Gif.cpp.o: In function `incTag':

/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: multiple definition of `incTag(unsigned int&, unsigned int&, unsigned int)'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: first defined here

CMakeFiles/pcsx2.dir/GS.cpp.o: In function `incTag':

/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: multiple definition of `incTag(unsigned int&, unsigned int&, unsigned int)'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: first defined here

CMakeFiles/pcsx2.dir/Hw.cpp.o: In function `incTag(unsigned int&, unsigned int&, unsigned int)':

/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: multiple definition of `incTag(unsigned int&, unsigned int&, unsigned int)'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: first defined here

CMakeFiles/pcsx2.dir/HwWrite.cpp.o: In function `incTag(unsigned int&, unsigned int&, unsigned int)':

/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: multiple definition of `incTag(unsigned int&, unsigned int&, unsigned int)'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: first defined here

CMakeFiles/pcsx2.dir/MTGS.cpp.o: In function `incTag(unsigned int&, unsigned int&, unsigned int)':

/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: multiple definition of `incTag(unsigned int&, unsigned int&, unsigned int)'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: first defined here

CMakeFiles/pcsx2.dir/Vif1_Dma.cpp.o: In function `incTag(unsigned int&, unsigned int&, unsigned int)':

/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: multiple definition of `incTag(unsigned int&, unsigned int&, unsigned int)'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: first defined here

CMakeFiles/pcsx2.dir/Vif1_MFIFO.cpp.o: In function `incTag(unsigned int&, unsigned int&, unsigned int)':

/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: multiple definition of `incTag(unsigned int&, unsigned int&, unsigned int)'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: first defined here

CMakeFiles/pcsx2.dir/Vif_Codes.cpp.o: In function `incTag':

/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:41: multiple definition of `incTag(unsigned int&, unsigned int&, unsigned int)'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: first defined here

CMakeFiles/pcsx2.dir/VUops.cpp.o: In function `incTag':

/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: multiple definition of `incTag(unsigned int&, unsigned int&, unsigned int)'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: first defined here

CMakeFiles/pcsx2.dir/x86/sVU_Lower.cpp.o: In function `incTag':

/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/./Gif_Unit.h:103: multiple definition of `incTag(unsigned int&, unsigned int&, unsigned int)'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: first defined here

CMakeFiles/pcsx2.dir/x86/microVU.cpp.o: In function `incTag':

/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/./Gif_Unit.h:103: multiple definition of `incTag(unsigned int&, unsigned int&, unsigned int)'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: first defined here

CMakeFiles/pcsx2.dir/FiFo.cpp.o: In function `WriteFIFO_GIF(u128 const*)':

FiFo.cpp:(.text+0x52a): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x53a): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x56d): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x576): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x598): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:FiFo.cpp:(.text+0x59d): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/FiFo.cpp.o: In function `WriteFIFO_GIF(u128 const*)':

FiFo.cpp:(.text+0x5ef): undefined reference to `Gif_AddBlankGSPacket(unsigned int, GIF_PATH)'

FiFo.cpp:(.text+0x5fc): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x602): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x61d): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x623): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x629): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:FiFo.cpp:(.text+0x633): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/FiFo.cpp.o: In function `WriteFIFO_GIF(u128 const*)':

FiFo.cpp:(.text+0x756): undefined reference to `Gif_MTGS_Wait()'

FiFo.cpp:(.text+0x75c): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x762): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x773): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x780): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x78d): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:FiFo.cpp:(.text+0x799): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/FiFo.cpp.o: In function `WriteFIFO_GIF(u128 const*)':

FiFo.cpp:(.text+0x80a): undefined reference to `Gif_MTGS_Wait()'

FiFo.cpp:(.text+0x815): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x81a): undefined reference to `gifUnit'

FiFo.cpp:(.text+0x864): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/FiFo.cpp.o: In function `Gif_Unit::Execute()':

FiFo.cpp:(.text._ZN8Gif_Unit7ExecuteEv[Gif_Unit::Execute()]+0x168): undefined reference to `Gif_AddCompletedGSPacket(GS_Packet&, GIF_PATH)'

FiFo.cpp:(.text._ZN8Gif_Unit7ExecuteEv[Gif_Unit::Execute()]+0x3f6): undefined reference to `Gif_AddCompletedGSPacket(GS_Packet&, GIF_PATH)'

FiFo.cpp:(.text._ZN8Gif_Unit7ExecuteEv[Gif_Unit::Execute()]+0x422): undefined reference to `Gif_FinishIRQ()'

FiFo.cpp:(.text._ZN8Gif_Unit7ExecuteEv[Gif_Unit::Execute()]+0x496): undefined reference to `Gif_HandlerAD(unsigned char*)'

FiFo.cpp:(.text._ZN8Gif_Unit7ExecuteEv[Gif_Unit::Execute()]+0x652): undefined reference to `Gif_MTGS_Wait()'

FiFo.cpp:(.text._ZN8Gif_Unit7ExecuteEv[Gif_Unit::Execute()]+0x672): undefined reference to `Gif_AddBlankGSPacket(unsigned int, GIF_PATH)'

CMakeFiles/pcsx2.dir/Gif.cpp.o: In function `_GIFchain()':

Gif.cpp:(.text+0x1d8): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/Gif.cpp.o: In function `CheckPaths(EE_EventType)':

Gif.cpp:(.text+0x207): undefined reference to `gifUnit'

Gif.cpp:(.text+0x23e): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/Gif.cpp.o: In function `mfifoGIFtransfer(int)':

Gif.cpp:(.text+0xa3d): undefined reference to `gifUnit'

Gif.cpp:(.text+0xa64): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/Gif.cpp.o:Gif.cpp:(.text+0xb06): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/Gif.cpp.o: In function `Gif_Unit::TransferGSPacketData(GIF_TRANSFER_TYPE, unsigned char*, unsigned int, bool)':

Gif.cpp:(.text._ZN8Gif_Unit20TransferGSPacketDataE17GIF_TRANSFER_TYPEPhjb[Gif_Unit::TransferGSPacketData(GIF_TRANSFER_TYPE, unsigned char*, unsigned int, bool)]+0x15c): undefined reference to `Gif_AddBlankGSPacket(unsigned int, GIF_PATH)'

Gif.cpp:(.text._ZN8Gif_Unit20TransferGSPacketDataE17GIF_TRANSFER_TYPEPhjb[Gif_Unit::TransferGSPacketData(GIF_TRANSFER_TYPE, unsigned char*, unsigned int, bool)]+0x3fb): undefined reference to `Gif_MTGS_Wait()'

Gif.cpp:(.text._ZN8Gif_Unit20TransferGSPacketDataE17GIF_TRANSFER_TYPEPhjb[Gif_Unit::TransferGSPacketData(GIF_TRANSFER_TYPE, unsigned char*, unsigned int, bool)]+0x4e6): undefined reference to `Gif_MTGS_Wait()'

CMakeFiles/pcsx2.dir/GS.cpp.o: In function `gsCSRwrite(tGS_CSR const&)':

GS.cpp:(.text+0x4b1): undefined reference to `gifUnit'

GS.cpp:(.text+0x52a): undefined reference to `gifUnit'

GS.cpp:(.text+0x537): undefined reference to `gifUnit'

GS.cpp:(.text+0x541): undefined reference to `gifUnit'

GS.cpp:(.text+0x569): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/GS.cpp.o:GS.cpp:(.text+0x571): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/SaveState.cpp.o: In function `SaveStateBase::FreezeInternals()':

/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/SaveState.cpp:210: undefined reference to `SaveStateBase::gifFreeze()'

CMakeFiles/pcsx2.dir/Vif_Codes.cpp.o: In function `int vifCode_MSCALF<1>(int, unsigned int const*)':

Vif_Codes.cpp:(.text._Z14vifCode_MSCALFILi1EEiiPKj[int vifCode_MSCALF<1>(int, unsigned int const*)]+0x1d): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z14vifCode_MSCALFILi1EEiiPKj[int vifCode_MSCALF<1>(int, unsigned int const*)]+0x28): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z14vifCode_MSCALFILi1EEiiPKj[int vifCode_MSCALF<1>(int, unsigned int const*)]+0x30): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z14vifCode_MSCALFILi1EEiiPKj[int vifCode_MSCALF<1>(int, unsigned int const*)]+0x3d): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z14vifCode_MSCALFILi1EEiiPKj[int vifCode_MSCALF<1>(int, unsigned int const*)]+0x48): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/Vif_Codes.cpp.o:Vif_Codes.cpp:(.text._Z14vifCode_MSCALFILi1EEiiPKj[int vifCode_MSCALF<1>(int, unsigned int const*)]+0x50): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/Vif_Codes.cpp.o: In function `int _vifCode_Direct<1>(int, unsigned char const*, bool)':

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x2d0): undefined reference to `Gif_AddBlankGSPacket(unsigned int, GIF_PATH)'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x2dd): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x2e3): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x2fe): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x304): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x30a): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/Vif_Codes.cpp.o:Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x314): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/Vif_Codes.cpp.o: In function `int _vifCode_Direct<1>(int, unsigned char const*, bool)':

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x36a): undefined reference to `Gif_MTGS_Wait()'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x370): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x376): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x387): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x394): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x3a1): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/Vif_Codes.cpp.o:Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x3b0): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/Vif_Codes.cpp.o: In function `int _vifCode_Direct<1>(int, unsigned char const*, bool)':

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x431): undefined reference to `Gif_MTGS_Wait()'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x46b): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x476): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x47b): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x4b3): undefined reference to `gifUnit'

Vif_Codes.cpp:(.text._Z15_vifCode_DirectILi1EEiiPKhb[int _vifCode_Direct<1>(int, unsigned char const*, bool)]+0x4d7): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/VUops.cpp.o:VUops.cpp:(.text+0x1daad): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/VUops.cpp.o: In function `VU1MI_XGKICK()':

VUops.cpp:(.text+0x1db8c): undefined reference to `Gif_AddBlankGSPacket(unsigned int, GIF_PATH)'

VUops.cpp:(.text+0x1db9c): undefined reference to `gifUnit'

VUops.cpp:(.text+0x1dba2): undefined reference to `gifUnit'

VUops.cpp:(.text+0x1dbbd): undefined reference to `gifUnit'

VUops.cpp:(.text+0x1dbc3): undefined reference to `gifUnit'

VUops.cpp:(.text+0x1dbc9): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/VUops.cpp.o:VUops.cpp:(.text+0x1dbd3): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/VUops.cpp.o: In function `VU1MI_XGKICK()':

VUops.cpp:(.text+0x1dc33): undefined reference to `Gif_MTGS_Wait()'

VUops.cpp:(.text+0x1dc39): undefined reference to `gifUnit'

VUops.cpp:(.text+0x1dc3f): undefined reference to `gifUnit'

VUops.cpp:(.text+0x1dc51): undefined reference to `gifUnit'

VUops.cpp:(.text+0x1dc62): undefined reference to `gifUnit'

VUops.cpp:(.text+0x1dc71): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/VUops.cpp.o:VUops.cpp:(.text+0x1dc8b): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/VUops.cpp.o: In function `VU1MI_XGKICK()':

VUops.cpp:(.text+0x1dd10): undefined reference to `Gif_MTGS_Wait()'

VUops.cpp:(.text+0x1dd1b): undefined reference to `gifUnit'

VUops.cpp:(.text+0x1dd20): undefined reference to `gifUnit'

VUops.cpp:(.text+0x1dd69): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/x86/sVU_Lower.cpp.o: In function `VU1XGKICK_MTGSTransfer(unsigned int)':

sVU_Lower.cpp:(.text+0x6a6c): undefined reference to `gifUnit'

sVU_Lower.cpp:(.text+0x6abc): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/x86/sVU_Lower.cpp.o:sVU_Lower.cpp:(.text+0x6ac9): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/x86/sVU_Lower.cpp.o: In function `VU1XGKICK_MTGSTransfer(unsigned int)':

sVU_Lower.cpp:(.text+0x6b4b): undefined reference to `Gif_AddBlankGSPacket(unsigned int, GIF_PATH)'

sVU_Lower.cpp:(.text+0x6b5b): undefined reference to `gifUnit'

sVU_Lower.cpp:(.text+0x6b61): undefined reference to `gifUnit'

sVU_Lower.cpp:(.text+0x6b7c): undefined reference to `gifUnit'

sVU_Lower.cpp:(.text+0x6b82): undefined reference to `gifUnit'

sVU_Lower.cpp:(.text+0x6b88): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/x86/sVU_Lower.cpp.o:sVU_Lower.cpp:(.text+0x6b92): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/x86/sVU_Lower.cpp.o: In function `VU1XGKICK_MTGSTransfer(unsigned int)':

sVU_Lower.cpp:(.text+0x6bf2): undefined reference to `Gif_MTGS_Wait()'

sVU_Lower.cpp:(.text+0x6bf8): undefined reference to `gifUnit'

sVU_Lower.cpp:(.text+0x6bfe): undefined reference to `gifUnit'

sVU_Lower.cpp:(.text+0x6c10): undefined reference to `gifUnit'

sVU_Lower.cpp:(.text+0x6c21): undefined reference to `gifUnit'

sVU_Lower.cpp:(.text+0x6c30): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/x86/sVU_Lower.cpp.o:sVU_Lower.cpp:(.text+0x6c4a): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/x86/sVU_Lower.cpp.o: In function `VU1XGKICK_MTGSTransfer(unsigned int)':

sVU_Lower.cpp:(.text+0x6ccf): undefined reference to `Gif_MTGS_Wait()'

sVU_Lower.cpp:(.text+0x6cda): undefined reference to `gifUnit'

sVU_Lower.cpp:(.text+0x6cdf): undefined reference to `gifUnit'

sVU_Lower.cpp:(.text+0x6d28): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/x86/microVU.cpp.o: In function `mVU_XGKICK_(unsigned int)':

microVU.cpp:(.text+0xd8f): undefined reference to `gifUnit'

microVU.cpp:(.text+0xddf): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/x86/microVU.cpp.o:microVU.cpp:(.text+0xdec): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/x86/microVU.cpp.o: In function `mVU_XGKICK_(unsigned int)':

microVU.cpp:(.text+0xe6e): undefined reference to `Gif_AddBlankGSPacket(unsigned int, GIF_PATH)'

microVU.cpp:(.text+0xe7e): undefined reference to `gifUnit'

microVU.cpp:(.text+0xe84): undefined reference to `gifUnit'

microVU.cpp:(.text+0xe9f): undefined reference to `gifUnit'

microVU.cpp:(.text+0xea5): undefined reference to `gifUnit'

microVU.cpp:(.text+0xeab): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/x86/microVU.cpp.o:microVU.cpp:(.text+0xeb5): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/x86/microVU.cpp.o: In function `mVU_XGKICK_(unsigned int)':

microVU.cpp:(.text+0xf15): undefined reference to `Gif_MTGS_Wait()'

microVU.cpp:(.text+0xf1b): undefined reference to `gifUnit'

microVU.cpp:(.text+0xf21): undefined reference to `gifUnit'

microVU.cpp:(.text+0xf33): undefined reference to `gifUnit'

microVU.cpp:(.text+0xf44): undefined reference to `gifUnit'

microVU.cpp:(.text+0xf53): undefined reference to `gifUnit'

CMakeFiles/pcsx2.dir/x86/microVU.cpp.o:microVU.cpp:(.text+0xf6d): more undefined references to `gifUnit' follow

CMakeFiles/pcsx2.dir/x86/microVU.cpp.o: In function `mVU_XGKICK_(unsigned int)':

microVU.cpp:(.text+0xff2): undefined reference to `Gif_MTGS_Wait()'

microVU.cpp:(.text+0xffd): undefined reference to `gifUnit'

microVU.cpp:(.text+0x1002): undefined reference to `gifUnit'

microVU.cpp:(.text+0x104b): undefined reference to `gifUnit'

collect2: ld returned 1 exit status

cristian...

Thanks Cottonvibes , you're good ... and Shadow Lady, you are amazing, and thanks for your help and 4 your time.

naik22...

Hope it speeds up tekken and gran turismo.

omar.con...

god of war 2 looks good in native resolution

Kratos escapes Hades where and when you use Amulet of Fates

Kar...

Nice as always, thank you for your hard work. Anyone want to list their FPS changes?

AndreyLegchilin

Great job.

Fixes movie in Silent Hill 4.

r4818:

http://postimage.org/image/13hakqpus/

r4822:

http://postimage.org/image/13h5m4odg/

cottonvibes

[email protected]: hopefully arcum or gregory can fix the linux builds soon.

refraction: path 3 masking games seem to work. persona 3 took me over a week of trying various stuff to get working; it was a pain xD

konaj...

good work don't know how you got this done when you're always talking on irc :p.

refraction

how about Destruction Derby? That was one of the more finicy games, persona was pretty lenient ;p

miser...

It's like christmas and Cottonvibes being a santa :O

Just first games I tried Dragon Ball Z Budokai Tenkaichi series got like at least 30% speedup or more, especially 1 and 2(3 was already very fast), feeling that code will have much more performance suprises. :O Huh, no more OC my AMD.

Thanks +1 x amount of existing games on ps2 you just made playable on AMD cpu's.:O

cottonvibes

refraction: Destruction Derby Arena seems to work as well as it did in our pcsx2 9.8 release.

its highly unstable due to gsdx crashing randomly in the game though (happens both in newGif and oldGif...)

cymek...

This revision appears to introduce some issues into The Simpsons Game (PAL):

r4820

http://postimage.org/image/181ma349w/

http://postimage.org/image/181pl5t9g/

r4822

http://postimage.org/image/181kmjrs4/

http://postimage.org/image/181nxmgro/

SNP_Tira...

Very nice Final Fantasy X speedup. I think that this is the first revision of PCSX2 that I have ever run that caused an immediate highly noticeable speedup.

shadowladyngemu

Really?

Didn't fix half screen in Fallout/Justice League which share the engine :/

jfre1...

I was going to post that this fixes the half screen issues in the Dark Alliance engine games (Dark Alliance 1 & 2, Fallout Brotherhood of Steel etc) but it appears to only be fixed in software mode.

The freeze at the menu screen, still occurs per usual if your not fast in flicking through the menu's.

You can actually get into the first introduction scene now in Dark Alliance 1. Couldn't do that before. However the graphics are MAJORLY messed up and there is severe SPS issues. First game I've seen with severe SPS issues in pcsx2 for quite some time (used to be very common in alot of games. Not so much these days). The game then runs at 12 fps before an error pops up saying "Oops ran out of video memory".

Good to see some progress in either case.

shadowladyngemu

@cymek:

The Simpsons game need "EE timing hack" gamefix now. Some games that needed EE timing hack don't need it now, some that didn't before do need it now, GameDB needs to be updated with the new gif.

This are some of the changes I found so far with the new gif:

Full Spectrum Warriors need EE timing for corrupted graphics

The Simpsons need EE timing for corrupted graphics

Drakengard don't EE timing (this one actually improved since enabling EE timing before fixed characters blinking but gave the char very colorful pants :p)

Mercenaries 2 need EE timing now for some flickering

BlackHawk Down + Team Sabre needs EE timing

Flatout games don't need EE timing anymore

Powerpuff Girls no need for EE timing hack

Onimusha 3 no need EE Timing hack

Lord of the Rings Aragorn's quest no need EE timing hack

Seven Lance Moromos no need EE timing

Venus and braves... likely not need anymore since seven Lance doesn't need it :p

Buffy - Chaos Bleeds doesn't need EE timing hack but if hangs ingame anyway :C

Area 51 got huge slowdown

Onimusha 4 has a big slowdown but only n 2d scenes

Outrun 2006/SP2 got some flickering and random garbage every few mins (still playable tho)

Tomb Raider Angel of Darkness black screens after first FMVs

Disney's Extreme Skate Adventure is playable now (was just intro before)

Klonoa 2 goes back to playable (crashed in volk city in 0.9.8)

Anyway, the DB needs to be updated as soon as someone finds more games that need/don't need the EE timing hack or do something else with the new gif changes, issue 881 collect them changes to the GameDB if anyone find anything else too :p

andutrache

i also have a problem with Bleach Blade Battlers 2 whenever there is a bankai with a screen withening effect garbage is displayed instead.

Sorry i can't provide screenshot because my paint is broken XD .

PS: EE timing gamefix doesn't help.

cymek...

@shadowladyngemu

Thanks for the hint. The game now looks just as it used to.

cottonvibes

andutrache: thanks for reporting.

rama mentioned the bleach bankai issue to me earlier; we'll be looking into it.

refraction

looking at simpsons, path3 masking has issues again >.< cheers for that lol... Ill look in to them at some point if you dont fix em.

shadowladyngemu

Simpsons looks fine with "EE timing hack"... unless you mean other different issues than the ones we noticed?

cymek...

@shadowladyngemu

I meant that it looked like in r4820.

I do have found another issue with The Simpsons, however unrelated to this revision:

https://code.google.com/p/pcsx2/issues/detail?id=1093

refraction

shadowladyngemu: Yes the issues above are Path3 Mask Syncing issues, which are avoided with the hack, they can probably be fixed up. But these timing issues will be more prevelant in other games id imagine.

ramapcsx2

refraction:

No other of the usual suspects has P3 mask problems.

You have more of those titles though, so better check em :p

shadowladyngemu

@refraction:

Way I see it, fixing it up for this game will bring the same timing issues in other games, in fact I suspect it's the same issue that was causing problems in Drakengard 1 while that one was working before with EE timing hack but was also giving other problems in that game like colorful pants in the main character... so as I see it it's better this way :p

refraction

Or we could just get it working properly :p ill let you test the stuff. With so many changes there's no way to say 1 thing was responsible for anything which is different now.

ex1991e...

Just tested Terminator 3 redemption with the latest release. The graphics are heavily corrupted. This has never happened in the older releases; ever since 0.98 that is.

http://postimage.org/image/1cb7abyv8/b30fbb40/

Makotech...

Both zone of the enders 2 and Devil summoner 2 now run extremely fast on my i5 2500k. This is a great commit!

danialho...

graphic regressions in Mana Khemia 2 [NTSC-U] caused by this change

danialho...

Buffy the Vampire Slayer - Chaos Bleeds [NTSC-U] &

Buffy the Vampire Slayer - Chaos Bleeds [PAL] freezing since this build

danialho...

which shadow lady already happened to catch above >.<

Revision 4822

This should fix MSVC 2010 compiling.

ex1991e...

Brilliant fix, the previous one caused Orphis's autobuilds to malfunction.

jadjkor...

thnx, it works again on MSVC 2010 SP1 =D

Revision 4823

pcsx2: deleted a lot of the old gif code.

some bits were kept for reference and should be deleted in the future (along

with the entire GIFpath.cpp)

naik22...

Bravooooooooooooo! :D

DanrleiS...

awesome. there were plenty of old files. You´re doing well.

Revision 4824

cmake: add new Gif Unit files.

gregory....

I did not test it (cause it commute time:p ) but hopefully it will work.

cottonvibes

thanks

luc...

Better but still failing linking with:

Linking CXX executable pcsx2

CMakeFiles/pcsx2.dir/Gif.cpp.o: In function `incTag':

/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: multiple definition of `incTag(unsigned int&, unsigned int&, unsigned int)'

CMakeFiles/pcsx2.dir/FiFo.cpp.o:/home/luca/.devels/pcsx2-svn/src/pcsx2-build/pcsx2/Gif_Unit.h:103: first defined here

CMakeFiles/pcsx2.dir/Gif_Unit.cpp.o: In function `incTag':